# Deserialization Optimization - uROTypes.FindROClass

**URL:** https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026
**Category:** Remoting SDK
**Created:** [October 21, 2016, 8:17am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026 "2016-10-21T08:17:20Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![Johannes\_Riemer](https://talk.remobjects.com/letter_avatar_proxy/v4/letter/j/d9b06d/32.png) [@Johannes\_Riemer](https://talk.remobjects.com/u/Johannes_Riemer)
#### Post date: [October 21, 2016, 8:17am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/1 "2016-10-21T08:17:20Z")

</div>

RemObjects SDK for Delphi  
Version: 8.3.93.1183

**uROTypes.FindROClass implements a linear search** over all registered TROComplexType classes. It is invoked by TROStreamSerializer at deserialization for every TROComplexType descendant.

For small messages and few registered TROComplexType classes this may be adequate.

In our project there are more than 600 registered TROComplexTypes, and we have messages with arrays containing thousands of TROComplexType descendants.

In this case, the linear search in FindROClass is inadequate. We patched it and replaced it with a hashtable based implementation.

Result of a test (640 registered TROComplexType classes, deserialization of ~7000 TROComplexType descendants):

- Without optimization: 100% serialization execution time
- With optimization: 65% serialization execution time

We would be glad to see a similar improvement in the original RemObjects SDK code base.

---

<div class="post-metadata">

### Author: ![RemObjectsSoftware](https://talk.remobjects.com/user_avatar/talk.remobjects.com/remobjectssoftware/32/15947_2.png) [@RemObjectsSoftware](https://talk.remobjects.com/u/RemObjectsSoftware)
#### Post date: [October 24, 2016, 7:28am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/2 "2016-10-24T07:28:02Z")

</div>

Thanks, logged as bugs://76477

---

<div class="post-metadata">

### Author: ![EvgenyK](https://talk.remobjects.com/user_avatar/talk.remobjects.com/evgenyk/32/16_2.png) [@EvgenyK](https://talk.remobjects.com/u/EvgenyK)
#### Post date: [October 25, 2016, 8:52am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/3 "2016-10-25T08:52:18Z")

</div>

can you upload your testcase that shows that uROTypes.FindROClass isn’t optimized, pls?  
as I see, we use standard TStringList.IndexOf that uses quicksort

---

<div class="post-metadata">

### Author: ![Johannes\_Riemer](https://talk.remobjects.com/letter_avatar_proxy/v4/letter/j/d9b06d/32.png) [@Johannes\_Riemer](https://talk.remobjects.com/u/Johannes_Riemer)
#### Post date: [October 25, 2016, 9:14am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/4 "2016-10-25T09:14:56Z")

</div>

From RemObject SDK 8.3.93.1183, uROTypes.pas:

```
var
  _ComplexTypes : TList{$IFDEF NEXTGEN}<TROComplexTypeClass>{$ENDIF};
//...
function FindROClass(const aClassName: string): TROComplexTypeClass;
var
  i: Integer;
begin
  Result := nil;
  for i := 0 to (_ComplexTypes.Count-1) do begin
    if (CompareText(TClass(_ComplexTypes.Items[i]).ClassName, aClassName)=0) then begin
      Result := TROComplexTypeClass(_ComplexTypes.Items[I]);
      Break;
    end;
  end;
end;

```

From RemObjects 9.0.97.1245, uROTypes.pas:

```
    var
      _ComplexTypes : TList{$IFDEF NEXTGEN}<TROComplexTypeClass>{$ENDIF};
    //...
    function FindROClass(const aClassName: string): TROComplexTypeClass;
    var
      i: Integer;
    begin
      for i := 0 to (_ComplexTypes.Count-1) do begin
        if (CompareText(TClass(_ComplexTypes.Items[i]).ClassName, aClassName)=0) then begin
          Result := TROComplexTypeClass(_ComplexTypes.Items[I]);
          Exit;
        end;
      end;
      {$IFDEF RO_RTTI_Support}
      Result := RORTTI_FindROClass(aClassName)
      {$ELSE}
      Result := nil;
      {$ENDIF}
    end;
```

---

<div class="post-metadata">

### Author: ![EvgenyK](https://talk.remobjects.com/user_avatar/talk.remobjects.com/evgenyk/32/16_2.png) [@EvgenyK](https://talk.remobjects.com/u/EvgenyK)
#### Post date: [October 25, 2016, 9:20am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/5 "2016-10-25T09:20:20Z")

</div>

this method was updated after 9.0.97.1245:

```auto
    for i := 0 to _ComplexTypes_new.Count-1 do begin
      if list1.IndexOf(_ComplexTypes_new[i]) <> -1 then Continue; // already processed
      //_TMyComplexList = {$IFDEF NEXTGEN}TDictionary<String,TROComplexTypeClass>{$ELSE}TStringList{$ENDIF};
      List := _TMyComplexList(_ComplexTypes_new.Objects[i]);
      {$IFDEF NEXTGEN}
      if List.ContainsKey(aClassName) then begin
        Result := List.Items[aClassName];
        Exit;
      end;
      {$ELSE}
      j := List.IndexOf(aClassName);
      if j <> -1 then begin
        Result := TROComplexTypeClass(List.Objects[j]);
        Exit;
      end;
      {$ENDIF}
    end;

```

---

<div class="post-metadata">

### Author: ![RemObjectsSoftware](https://talk.remobjects.com/user_avatar/talk.remobjects.com/remobjectssoftware/32/15947_2.png) [@RemObjectsSoftware](https://talk.remobjects.com/u/RemObjectsSoftware)
#### Post date: [October 26, 2016, 10:52am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/6 "2016-10-26T10:52:33Z")

</div>

bugs://76477 got closed with status nochangereq.

---

<div class="post-metadata">

### Author: ![RemObjectsSoftware](https://talk.remobjects.com/user_avatar/talk.remobjects.com/remobjectssoftware/32/15947_2.png) [@RemObjectsSoftware](https://talk.remobjects.com/u/RemObjectsSoftware)
#### Post date: [September 1, 2020, 5:21am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/7 "2020-09-01T05:21:18Z")

</div>

Logged as [bugs://i64365](https://www.remobjects.com/portal/bugs/?id=i64365).

---

<div class="post-metadata">

### Author: ![RemObjectsSoftware](https://talk.remobjects.com/user_avatar/talk.remobjects.com/remobjectssoftware/32/15947_2.png) [@RemObjectsSoftware](https://talk.remobjects.com/u/RemObjectsSoftware)
#### Post date: [September 1, 2020, 5:21am UTC](https://talk.remobjects.com/t/deserialization-optimization-urotypes-findroclass/11026/8 "2020-09-01T05:21:21Z")

</div>

[bugs://i64365](https://www.remobjects.com/portal/bugs/?id=i64365) was closed as fixed.
