IslandRTL - Git Guide?

Elements
, ,
1

Hello Dude’s,

i would love to know:

How are is your internal Guide for contributing to IslandRTL, i mean:

1)When do you make commits exactly?
2)Based on which Patterns are you commiting and commenting your src-code?
3)When do you think its time to pull the locale-repo to github or do you make this instantly, on every commit?
4)Do you have a pattern for the commit-comments?
5)etc…

I want to know better, how are you working on those at your Company, so that I can follow your rules even im not working at remobject :slight_smile:

–Shpend

2

There’s no specific rules. if you have something you consider worth contributing, submit a pull request with it. We’ll have a look, and if its (a) good and (b) fits with what we need, we’ll merge it, if and when we find the time.

1 Like
3

Ok, but 1 more question about this:

Could you give me good tipp, when do you commit stuff/changes?

Do you do this of every function, or every small but relevant Change?

Some hints, how you work would be nice ^^

4

I think when you do pull requests you should try and have them contain as little as possible. RemObjects are more likely to accept the change.

1 Like
5

Yes. your pull request should be self-contained, fully functional AND complete. dont submit one fr 3 separate features/changes at once; and don’t submit a partially fixed request. that said you can commit half-way thru, of course — just don’t submit the request yet.

me personally, i commit when

  • i’m done
    or
  • i need top stop or leave work or the task for a while
    or
  • i need a full build cycle with the current (potentially partial) change.
1 Like
6

Thanks a lot guys!

I just want to get sure, that i can work optimally for my purposes.

1 Like