In asking CB to review a unit in my project CB suggested a bug for potential of editing wrong record. So I suggested to CB that it may have missed it. Does this change future analysis?
Thanks
You
so do you not see the MasterSource on TblSOrder that connects which OrderID is used in updating printed field for you assesment of bugs
→ I’m going back to the form definition and dataset wiring to verify
→ whether tblSOrder.MasterSource already keeps it synchronized with
→ qrySOrder before I revise that assessment.
→ You’re right to challenge that point. I’m going back to the actual
→ form definition/source now, specifically to verify tblSOrder
→ Source / MasterFields and whether that makes the Edit/Post
→ the current qrySOrder record.
→ I’m checking the actual form code now to verify whether TblSOrder
→ .MasterSource
→ that affects the update bug assessment.
Error
Object reference not set to an instance of an object.
→ I’m going back to the form unit to verify the dataset wiring around
→ tblSOrder before I answer that specific point.
→ You’re right to challenge that point. I’m going back to the actual
→ form definition/source to verify tblSOrder.MasterSource/master
→ fields before I correct the bug assessment.
→ You’re right to challenge that.
→ If TblSOrder is a detail dataset with a MasterSource tied to
→ the current OrderID, then my earlier statement that it “updates
→ the wrong row” is too strong and likely incorrect. In that case
→ , Edit/Post would apply to the currently-mastered order record
→ , so the update path is coherent.
→ What I should have said is:
→ - the code is not obviously wrong just because it doesn’t call
→ Locate
→ - the real question is whether the MasterSource is always correctly
→ - if it is, then the printed-flag update bug is not high-confidence
→ **.
→ - remove or downgrade
→ - keep only the concern if there’s evidence TblSOrder can be out
→ of sync with qrySOrder or the master relation isn’t established
→ in all modes.