Eventrepository - memory leak?

Remoting SDK
1

Hi,

Using Delphi 12.2, RODA 10.0.0.1607

Having a service

type
  [ROService(SvcEvents, SvcEventsID)]
  [RONamespace(__RODLLibraryNamespace)]
  [ROSynchronizedSingletonClassFactory]
  TServiceEvents = class(TRORemoteDataModule, IServiceEvents)
    erEvents: TROInMemoryEventRepository;
    procedure RORemoteDataModuleCreate(Sender: TObject);
  private
  public
     [ROServiceMethod]
     procedure SendMessage(const aMessage: string);
  end;

implementation

{%CLASSGROUP 'Vcl.Controls.TControl'}
{$R *.dfm}

uses
  Services.Panacee,
  Units.Logging;

procedure TServiceEvents.RORemoteDataModuleCreate(Sender: TObject);
begin
  inherited;
  SessionManager := PanaceeService.smSessions;
end;

procedure TServiceEvents.SendMessage(const aMessage: string);
var
  aEvent: IROEventWriter<ICommonEvents>;
begin
  Log.Log(ltInfo, ClassName, 'Service Events SendMessage', 'Session: ' + Session.SessionID.ToString);
  aEvent := erEvents.GetWriter<ICommonEvents>(Session.SessionID);
  aEvent.ExcludeSender := False;
  aEvent.ExcludeSessionList := True;
  aEvent.Event.OnSendMessage(aMessage);
end;

initialization
  RegisterCodeFirstService(TServiceEvents);

On clientside

type
  TEventMediator = class(TComponent, ICommonEvents)
  private
    FEventReceiver: TROEventReceiver;
  public
    constructor Create(AOwner: TComponent); override;
    destructor Destroy; override;

    procedure RegisterEvents;
    procedure UnregisterEvents;

    procedure OnSendMessage(const aMessage: UnicodeString);
  end;

procedure TEventMediator.RegisterEvents;
begin
  FEventReceiver.Interval := 1000;
  FEventReceiver.Channel := PanaceeSvc.chHTTP;
  FEventReceiver.Message := PanaceeSvc.msgBIN;

  FEventReceiver.ServiceName := 'ServiceEvents';
  FEventReceiver.RegisterEventHandlers([EID_CommonEvents],[Self]);

  FEventReceiver.Activate;
end;

So, client starts (just login) and calls RegisterEvents which is nothing more than setting some properties of the TROEventReceiver and activate it.

Stopping the server (or service) results in a memory leak of TROBinaryMemoryStream.

What is wrong in this?

Regards,

Filip

2

Hi,

can you attach full testcase, pls?

usually we recommend to put event repository to server data module, but you put it to service …

You can drop email to support@ for keeping privacy

3

Hi Evgeny

usually we recommend to put event repository to server data module, but you put it to service …

Moving the TROInMemoryEventRepository to the server datamodule did the trick. No more memory leaks.

So, I guess putting an EventRepository on a service results in a memory leak (or several leaks) of TROBinaryMemoryStream.

Regards,

Filip

4

Hi,

Session manager and event repository is global thread safe components.

super servers (SuperTCP/SuperHTTP) work with specific EventRepository:

property EventRepository: TROEventRepository read fEventRepository write SetEventRepository;

so it won’t work properly in case EventRepository is put on service …

1 Like