Suggested fix for uROJSONParser

Remoting SDK
1

Hi guys, been doing some work on uROJSONParser today and I suggest you review TROJSONValue.IntLoadFromStream to support a trailing comma ( , ) in an array. Its common to see servers output such a stream and javascript in the browser seems to handle it. Javascript in a browser seems to handle this as it should be ignored. At the very least, you should put a null item on the end of the array if re-factoring the entire code is too hard so at least it doesn’t crash trying to turn ] into a number.

else if lChar = ']' then begin // array
  clear;
end
else begin // number
  AsNumber:= ReadNumber(AStream);
end;

let x = [1,2,3,4,5,];
x.forEach(function(value) { console.log(value); } );

let x = [1,2,3,4,5,null];
x.forEach(function(value) { console.log(value); } );

3

Hi,

from https://www.json.org/json-en.html :

Untitled
Untitled921×342 35 KB

as for me, it doesn’t allow to have empty value like [1,2,3,4,5,]

even Delphi std classes doesn’t accept [1,2,3,4,5,]:

Untitled
Untitled1920×1080 276 KB

try it by yourself:

program Project3;
{$APPTYPE CONSOLE}
{$R *.res}
uses
  System.SysUtils,JSON;
const
  s = '[1,2,3,4,5,]';
begin
  TJSonObject.ParseJSONValue(s, true, true);
end.
4

I wouldn’t use the delphi library as a guide to anything. Try it in chrome and you will see. If it works in chrome and therefore in NodeJS, then that’s the standard :slight_smile:
And its the same in Firefox and Spidermonkey, so therefore, that’s just how it is.
The reason we use your library instead of the Delphi one is because the Delphi one is rubbish.

5

Hi,

according to https://www.ecma-international.org/publications-and-standards/standards/ecma-404/ :

Untitled
Untitled1087×547 23.1 KB

IMHO, official standard has priority under Chrome & Co

6

And that’s why we haven’t renewed our license in 3 years :slight_smile:

8

Agree we should support this (and it should NOT result in an extra null item, IMHO)

9

Logged as bugs://E26699.

10

bugs://E26699 was closed as fixed.

1 Like