Toffee AddYears

JohnMoshakis · December 15, 2020, 3:02am

Hi,

Isn’t the Toffee version of AddYears wrong ?

remobjects/RTL2/blob/master/Source/DateTime.pas#L531


  result := new DateTime(fDateTime.AddMilliseconds(Value));
  {$ENDIF}
end;
method DateTime.AddYears(Value: Integer): DateTime;
begin
  {$IF COOPER}
  result := DateTime(mapped.clone);
  Calendar(result).add(Calendar.YEAR, Value);
  {$ELSEIF TOFFEE}
  result := &Add(TimeSpan.FromMilliseconds(Value));
  {$ELSEIF ECHOES OR ISLAND}
  result := new DateTime(fDateTime.AddYears(Value));
  {$ENDIF}
end;
method DateTime.Add(Value: TimeSpan): DateTime;
begin
  result := new DateTime(self.Ticks + Value.Ticks);
end;

That looks like its trying to add a timespan with 1 ms when it should be a years worth.

Cheers,
John

mh · December 15, 2020, 12:15pm

Sure looks like. checking.

mh · December 15, 2020, 12:20pm

Looks like all the Add*s are broken. this one just more than the others. the others set the mondy/day/week instead of additional it, AFAICT. will review & fix.

mh · December 15, 2020, 12:38pm

Proper fix for all methods is in.